From: Arnd Bergmann Subject: Re: [PATCH] fs/locks.c: prepare for BKL removal Date: Tue, 21 Sep 2010 22:09:51 +0200 Message-ID: <201009212209.51956.arnd@arndb.de> References: <1284815371-5843-1-git-send-email-arnd@arndb.de> <20100920160729.96872d12.sfr@canb.auug.org.au> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Stephen Rothwell , linux-kernel@vger.kernel.org, Matthew Wilcox , Christoph Hellwig , Trond Myklebust , "J. Bruce Fields" , Andrew Morton , Miklos Szeredi , Frederic Weisbecker , Ingo Molnar , John Kacur , linux-fsdevel@vger.kernel.org, gregf@hq.newdream.net To: Sage Weil Return-path: Received: from moutng.kundenserver.de ([212.227.126.187]:57590 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131Ab0IUUKc (ORCPT ); Tue, 21 Sep 2010 16:10:32 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tuesday 21 September 2010 18:12:07 Sage Weil wrote: > On Mon, 20 Sep 2010, Stephen Rothwell wrote: > > > On Sun, 19 Sep 2010 20:59:01 -0700 (PDT) Sage Weil wrote: > > > > > > I suspect the easiest thing is to leave Ceph out of this stage of your > > > series, I'll switch lock_kernel() to lock_flocks() once that exists > > > upstream. Unless there is a better way? > > > > Maybe someone could write a trivial implementation of lock_flocks() (i.e. > > one that does not make any changes to behaviour) and ask Linus to take it > > now in preparation for the next merge window (he has done that before). > > That way, more of this could be put into individual other trees and avoid > > more conflicts ... > > This sounds like the easiest solution to me. Something as simple as > > #define lock_flocks lock_kernel > #define unlock_flocks unlock_kernel > > in fs.h? Sounds fine to me. I don't think it's necessary but if you prefer to do it, you can have my Ack. Arnd