From: Mike Frysinger Date: Fri, 24 Sep 2010 13:04:52 -0400 Subject: [U-Boot] [PATCH] board/armltd/integrator/split_by_variant.sh: fix 'echo -n' In-Reply-To: <1285345672-35800-1-git-send-email-andreas.devel@googlemail.com> References: <1285345672-35800-1-git-send-email-andreas.devel@googlemail.com> Message-ID: <201009241304.53817.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, September 24, 2010 12:27:52 Andreas Bie?mann wrote: > - echo -n "#define CONFIG_CM720T" >> ${config_file} > - echo " 1 /* CPU core is ARM720T */ " >> ${config_file} > + cat >> ${config_file} << _EOF > +#define CONFIG_CM720T 1 /* CPU core is ARM720T */ > +_EOF changing multiline echos to a cat makes sense, but using cat for a single line is overkill. a simple `echo "..."` is better. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100924/76193dd9/attachment.pgp