From: Ingo Molnar Date: Mon, 27 Sep 2010 06:25:10 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon (coretemp): Fix build breakage if Message-Id: <20100927062510.GA17825@elte.hu> List-Id: References: <1285530603-2510-1-git-send-email-guenter.roeck@ericsson.com> In-Reply-To: <1285530603-2510-1-git-send-email-guenter.roeck@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guenter Roeck Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, Fenghua Yu , Jean Delvare * Guenter Roeck wrote: > Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced > a build breakage if CONFIG_SMP is undefined. This patch > fixes the problem. > > Reported-by: Ingo Molnar > Cc: Fenghua Yu > Cc: Jean Delvare > Signed-off-by: Guenter Roeck > > --- > drivers/hwmon/coretemp.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c > index baa842a..58a3c2d 100644 > --- a/drivers/hwmon/coretemp.c > +++ b/drivers/hwmon/coretemp.c > @@ -503,9 +503,11 @@ static void coretemp_device_remove(unsigned int cpu) > list_del(&p->list); > mutex_unlock(&pdev_list_mutex); > kfree(p); > +#ifdef CONFIG_SMP > for_each_cpu(i, cpu_sibling_mask(cpu)) > if (i != cpu && !coretemp_device_add(i)) > break; > +#endif Wont this result in an 'unused variable i' compiler warning? Thanks, Ingo _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors