From: Amit Shah Subject: Re: [PATCH 1/1] virtio_console: perf-test fix [FIX] read-out all data after perf-test [FIX] code clean-up Date: Tue, 28 Sep 2010 12:01:50 +0530 Message-ID: <20100928063149.GA3812@amit-laptop.redhat.com> References: <1285243912-28385-1-git-send-email-ldoktor@redhat.com> <1285243912-28385-2-git-send-email-ldoktor@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jzupka@redhat.com, autotest@test.kernel.org, kvm@vger.kernel.org, lmr@redhat.com To: Lukas Doktor Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37819 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756738Ab0I1Gbs (ORCPT ); Tue, 28 Sep 2010 02:31:48 -0400 Content-Disposition: inline In-Reply-To: <1285243912-28385-2-git-send-email-ldoktor@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On (Thu) Sep 23 2010 [14:11:52], Lukas Doktor wrote: > @@ -829,6 +832,11 @@ def run_virtio_console(test, params, env): > exit_event.set() > thread.join() > > + # Let the guest read-out all the remaining data > + while not _on_guest("virt.poll('%s', %s)" > + % (port[1], select.POLLIN), vm, 2)[0]: > + time.sleep(1) This is just polling the guest, not reading out any data? (BTW POLLIN will be set if host is disconnected and there's no data to read, so ensure you don't enter an infinite loop here.) Amit