From: Wolfgang Denk Date: Tue, 28 Sep 2010 19:33:23 +0200 Subject: [U-Boot] [PATCH V2 2/7] Adding more control to physical address mapping In-Reply-To: <1285691891-32700-2-git-send-email-yorksun@freescale.com> References: <1285691891-32700-1-git-send-email-yorksun@freescale.com> <1285691891-32700-2-git-send-email-yorksun@freescale.com> Message-ID: <20100928173323.ED12AD52190@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear York Sun, In message <1285691891-32700-2-git-send-email-yorksun@freescale.com> you wrote: > A worker function __setup_ddr_tlbs() is introduced to implement more > control on physical address mapping. The __ name prefix has a special, reserved meaning. What is your rationale for using it here? > +unsigned int setup_ddr_tlbs(unsigned int memsize_in_meg) > +{ > + return > + __setup_ddr_tlbs(CONFIG_SYS_DDR_SDRAM_BASE, memsize_in_meg); Remove line break. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The first thing we do is kill all the lawyers. (Shakespeare. II Henry VI, Act IV, scene ii)