From: Arnd Bergmann Subject: Re: [PATCH] Remove BKL usage from ncpfs Date: Wed, 29 Sep 2010 14:31:54 +0200 Message-ID: <201009291431.54709.arnd@arndb.de> References: <20100926234733.GA31884@vana.vc.cvut.cz> <201009271616.42190.arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, aia21@cam.ac.uk, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk To: Petr Vandrovec Return-path: Received: from moutng.kundenserver.de ([212.227.17.10]:54008 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752586Ab0I2McB (ORCPT ); Wed, 29 Sep 2010 08:32:01 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Monday 27 September 2010, Petr Vandrovec wrote: > Yes, I believe it is not necessary. fill_super(sb) should not run > concurrently with anything else because MS_BORN and MS_ACTIVE are not > set yet so nobody else should use this sb from VFS. One thing which > seems to be missing is doing lock_sock() around code which sets > sk->sk_{error_report,data_ready,write_space} - there does not seem to > be anything else to protect ipv4/ipv6/ipx from seeing partially > updated pointers on systems where these writes are not atomic - that's > ncpfs2.patch. > > Also I found some whitespace problems, and one missing const, so if > you could merge ncpfs3.patch & ncpfs4.patch with original BKL removal, > it would be cool. Or I can resend all 4 patches as one bigger diff if > you prefer. Generally I prefer separate patches for changes that make sense to be split, so I left ncpfs2.patch separately. I think it would be nice to do the first patch in smaller steps, but since you are the maintainer, I'm not going to complain ;-) Applied both patches to my bkl/vfs series now. Arnd