From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Wed, 29 Sep 2010 16:02:42 +0100 Subject: [PATCH 01/14] ARM: mmu: Setup MT_MEMORY and MT_MEMORY_NONCACHED L1 entries In-Reply-To: References: <1284716878-27667-1-git-send-email-santosh.shilimkar@ti.com> <1284716878-27667-2-git-send-email-santosh.shilimkar@ti.com> Message-ID: <20100929150242.GA21646@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Sep 29, 2010 at 03:51:21PM +0100, Catalin Marinas wrote: > Hi Santosh, > > Santosh Shilimkar wrote: > > This patch populates the L1 entries for MT_MEMORY and MT_MEMORY_NONCACHED > > types so that at boot-up, we can map memories outside system memory > > at page level granularity > > > > Previously the mapping was limiting to section level, which creates > > unnecessary addiotional mapping for which physical memory may not > > present. On the newer ARM with speculation, this is dangerous and can > > result in untraceable aborts. > > > > Signed-off-by: Santosh Shilimkar > > Reviewed-by: Russell King > > --- > > arch/arm/mm/mmu.c | 17 +++++++++++++++-- > > 1 files changed, 15 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c > > index 6e1c4f6..3e986a6 100644 > > --- a/arch/arm/mm/mmu.c > > +++ b/arch/arm/mm/mmu.c > > @@ -246,6 +246,9 @@ static struct mem_type mem_types[] = { > > .domain = DOMAIN_USER, > > }, > > [MT_MEMORY] = { > > + .prot_pte = L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY | > > + L_PTE_USER | L_PTE_EXEC, > > + .prot_l1 = PMD_TYPE_TABLE, > > Just a quick question - does this need to have L_PTE_USER? Is it > read-only or it needs L_PTE_WRITE as well? Eek. It should not have L_PTE_USER or else it will be accessible to userspace.