From: Wolfgang Denk Date: Fri, 01 Oct 2010 09:57:49 +0200 Subject: [U-Boot] [PATCH] xyzModem.c Packet buffer dynamic allocate In-Reply-To: <87sk0q1mnf.wl%ysato@users.sourceforge.jp> References: <87sk0q1mnf.wl%ysato@users.sourceforge.jp> Message-ID: <20101001075749.B131C153A7E@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Yoshinori Sato, In message <87sk0q1mnf.wl%ysato@users.sourceforge.jp> you wrote: > > It changes reduce bss usage. ... and increases the load on the malloc arean. > Ymodem receive buffer dinamic allocation. As far as I can see we increase the code size, and shift a fixed sized buffer from bss to the maloc arene. I don't consider this an improvement, but I may be overlooking something. Which advantages do you see with the changed code? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If the facts don't fit the theory, change the facts. -- Albert Einstein