From: akpm@linux-foundation.org Subject: [patch 2/3] vfs: sparse: remove a warning on OPEN_FMODE() Date: Fri, 01 Oct 2010 14:20:23 -0700 Message-ID: <201010012120.o91LKNEY021442@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Cc: linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, namhyung@gmail.com To: viro@zeniv.linux.org.uk Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:50996 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754858Ab0JAVUY (ORCPT ); Fri, 1 Oct 2010 17:20:24 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Namhyung Kim AND-ing FMODE_* constant with normal integer results in following sparse warnings. Fix it. fs/open.c:662:21: warning: restricted fmode_t degrades to integer fs/anon_inodes.c:123:34: warning: restricted fmode_t degrades to integer Signed-off-by: Namhyung Kim Cc: Al Viro Signed-off-by: Andrew Morton --- include/linux/fs.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -puN include/linux/fs.h~vfs-remove-a-warning-on-open_fmode include/linux/fs.h --- a/include/linux/fs.h~vfs-remove-a-warning-on-open_fmode +++ a/include/linux/fs.h @@ -2490,9 +2490,11 @@ int proc_nr_files(struct ctl_table *tabl int __init get_filesystem_list(char *buf); +#define __FMODE_NONOTIFY ((__force int) FMODE_NONOTIFY) + #define ACC_MODE(x) ("\004\002\006\006"[(x)&O_ACCMODE]) #define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE) | \ - (flag & FMODE_NONOTIFY))) + (flag & __FMODE_NONOTIFY))) #endif /* __KERNEL__ */ #endif /* _LINUX_FS_H */ _