From: "Rafael J. Wysocki" Subject: Re: [PATCH] PM: add synchronous runtime interface for interrupt handlers Date: Sun, 3 Oct 2010 00:06:33 +0200 Message-ID: <201010030006.33454.rjw@sisk.pl> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:38064 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751571Ab0JBWHT (ORCPT ); Sat, 2 Oct 2010 18:07:19 -0400 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Alan Stern Cc: Linux-pm mailing list , Kevin Hilman , Partha Basak , linux-omap@vger.kernel.org On Saturday, October 02, 2010, Alan Stern wrote: > On Fri, 1 Oct 2010, Rafael J. Wysocki wrote: ... > > At the moment it suspends when the network cable is removed from the device > > and the hack I mentioned is used during the resume after the cable has been > > reinserted (it checks if the cable is still there and schedules suspend if not). > > That does seem like a strange hack. Instead of scheduling a suspend, > why not simply do a suspend as soon as you learn that the cable has > been removed again? Is there a problem about the connection status > bouncing? I don't remember 100%, but ISTR there was a problem with that. > > If we removed the immediate idle notification after a successful resume, it > > might need to be reworked slightly. > > My suggestion was that we remove the idle notification after a failed > suspend, not the notification after a successful resume. And I said I was fine with that. Rafael