From: Jesse Barnes Subject: Re: [git pull] i915 regressions Date: Sun, 3 Oct 2010 08:32:38 -0700 Message-ID: <20101003083238.55885ac3@jbarnes-x201> References: <8u3s94$gm76dr@orsmga002.jf.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cpoproxy3-pub.bluehost.com (cpoproxy3-pub.bluehost.com [67.222.54.6]) by gabe.freedesktop.org (Postfix) with SMTP id 675D49E70A for ; Sun, 3 Oct 2010 08:33:17 -0700 (PDT) In-Reply-To: <8u3s94$gm76dr@orsmga002.jf.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Linus Torvalds , linux-kernel@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Sun, 03 Oct 2010 11:33:36 +0100 Chris Wilson wrote: > Hi Linus, > > still a fair few regressions popping up in the i915 driver. Julia > spotted an old bug in our error handling that could cause the > aperture to be consumed with unpinnable buffers, Keith found that the > wait-for-vblank handling changes were not correct for DP, Jesse > failed at basic math (and nobody spotted the mistake!) and I I think I'm innocent on this one! I think Eric just introduced a merge error when he pulled in the i915 changes for IPS. I was using do_div (which modifies the first arg), but Eric changed to to div_u64 to fix a build error of some kind, but forgot to fix things up due to the changed semantics. At any rate, it's a good fix and gives the IPS driver good GMCH power values again. -- Jesse Barnes, Intel Open Source Technology Center