From: Wolfgang Denk Date: Mon, 04 Oct 2010 10:32:31 +0200 Subject: [U-Boot] AT91 clock and timer cleanups (was: ARM relocation, probably trivial mistake - back to original problem) In-Reply-To: <4CA985DC.4000208@emk-elektronik.de> References: <4CA49746.2050301@emk-elektronik.de> <4CA4AEFF.3050101@denx.de> <20100930174308.070ECD2B48C@gemini.denx.de> <4CA570D3.9040406@denx.de> <4CA57468.6090702@free.fr> <4CA57762.3000201@denx.de> <4CA5821E.3070108@emk-elektronik.de> <4CA5873B.6040907@free.fr> <4CA590E6.6070701@emk-elektronik.de> <4CA59B89.6090207@denx.de> <4CA5BB7A.8050304@emk-elektronik.de> <20101001105506.A64D41539A0@gemini.denx.de> <4CA5BFEF.3090208@emk-elektronik.de> <20101001112125.4076E153A7E@gemini.denx.de> <4CA5C7DE.6010300@emk-elektronik.de> <20101001115908.A34411539A0@gemini.denx.de> <4CA5D26D.2090505@emk-elektronik.de> <20101001124946.7DE29153A7E@gemini.denx.de> <4CA5F4CE.8050002@emk-elektronik.de> <4CA985DC.4000208@emk-elektronik.de> Message-ID: <20101004083231.508F51539A0@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Reinhard Meyer, In message <4CA985DC.4000208@emk-elektronik.de> you wrote: > > The Qs that remain now are: > > 1. currently I see about 8 CONFIG_AT91SAMxxx defines required > (not only 2 like above). The method is still undecided how to > handle this. Add "CONFIG_AT91SAM9_FAMILY" to "common.h"? Or put > all 8 defined() into "global_data.h" (would give 4 lines there)? You wille ventually need this in other locations as well, so please add a single 4-line-#if to some appropriate header file; if there is no better file for AT91 I will accept this for common.h > 2. How many patches would this change need, and who would collect them? > It affects at worst 3 areas: > common.h, arm/global_data.h, at91/clock.c+timer.c --- > Or is it ok to put that into one patch and add it later to my atmel tree? I see two patches: Patch 1 will change the #if and introduce CONFIG_AT91SAM9_FAMILY instead. Patch 2 will fix at91/clock.c+timer.c Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de They say a little knowledge is a dangerous thing, but it is not one half so bad as a lot of ignorance. - Terry Pratchett, _Equal Rites_