From: Wolfgang Denk Date: Mon, 04 Oct 2010 19:00:10 +0200 Subject: [U-Boot] AT91 clock and timer cleanups In-Reply-To: <4CA9EB88.5000203@emk-elektronik.de> References: <4CA49746.2050301@emk-elektronik.de> <4CA4AEFF.3050101@denx.de> <20100930174308.070ECD2B48C@gemini.denx.de> <4CA570D3.9040406@denx.de> <4CA57468.6090702@free.fr> <4CA57762.3000201@denx.de> <4CA5821E.3070108@emk-elektronik.de> <4CA5873B.6040907@free.fr> <4CA590E6.6070701@emk-elektronik.de> <4CA59B89.6090207@denx.de> <4CA5BB7A.8050304@emk-elektronik.de> <20101001105506.A64D41539A0@gemini.denx.de> <4CA5BFEF.3090208@emk-elektronik.de> <20101001112125.4076E153A7E@gemini.denx.de> <4CA5C7DE.6010300@emk-elektronik.de> <20101001115908.A34411539A0@gemini.denx.de> <4CA5D26D.2090505@emk-elektronik.de> <20101001124946.7DE29153A7E@gemini.denx.de> <4CA5F4CE.8050002@emk-elektronik.de> <4CA985DC.4000208@emk-elektronik.de> <20101004083231.508F51539A0@gemini.denx.de> <4CA99373.7020704@emk-elektronik.de> <20101004084945.C99DE153A7E@gemini.denx.de> <4CA995D7.5010008@emk-elektronik.de> <20101004090325.87A921539A0@gemini.denx.de> <4CA99A63.402@emk-elektronik.de> <4CA9EB88.5000203@emk-el ektronik.de> Message-ID: <20101004170010.9FE96153A7E@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Reinhard Meyer, In message <4CA9EB88.5000203@emk-elektronik.de> you wrote: > > 1. The board's config file defines "CONFIG_AT91FAMILY" like this: > /* SoC */ > #define CONFIG_ARM926EJS 1 /* ARM926EJS Core */ > #define CONFIG_AT91FAMILY 1 /* it's a member of AT91 */ > #define CONFIG_AT91SAM9260 1 /* Atmel AT91SAM9260 based SoC */ > #define CONFIG_AT91SAM9XE 1 /* more specific: AT91SAM9XE */ Out of principle: please omit the "1" in all such cases unless you really want to pass or test for such a numeric value anywhere. As far as I can tell all relevant code uses only "#ifdef" or "defined(...)", so not to confuse people better omit the irrelevant value. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Hiring experienced unix people is like a built-in filter against idiots. Hiring experienced NT people provides no such guarantee. -- Miguel Cruz in WgL96.349$CC.122704 at typhoon2.ba-dsg.net