From: Christoph Hellwig Subject: Re: [PATCH 02/18] fs: Convert nr_inodes and nr_unused to per-cpu counters Date: Fri, 8 Oct 2010 03:01:08 -0400 Message-ID: <20101008070108.GA23595@lst.de> References: <1286515292-15882-1-git-send-email-david@fromorbit.com> <1286515292-15882-3-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Dave Chinner Return-path: Received: from canuck.infradead.org ([134.117.69.58]:44516 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277Ab0JHHBK (ORCPT ); Fri, 8 Oct 2010 03:01:10 -0400 Content-Disposition: inline In-Reply-To: <1286515292-15882-3-git-send-email-david@fromorbit.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Oct 08, 2010 at 04:21:16PM +1100, Dave Chinner wrote: > From: Dave Chinner > > The number of inodes allocated does not need to be tied to the > addition or removal of an inode to/from a list. If we are not tied > to a list lock, we could update the counters when inodes are > initialised or destroyed, but to do that we need to convert the > counters to be per-cpu (i.e. independent of a lock). This means that > we have the freedom to change the list/locking implementation > without needing to care about the counters. > > Based on a patch originally from Eric Dumazet. > > Signed-off-by: Dave Chinner Looks good except for a spurious whitespace change in inode_init_early. Reviewed-by: Christoph Hellwig