From: Christoph Hellwig Subject: Re: [PATCH 07/18] exofs: use iput() for inode reference count decrements Date: Fri, 8 Oct 2010 03:21:19 -0400 Message-ID: <20101008072119.GF23595@lst.de> References: <1286515292-15882-1-git-send-email-david@fromorbit.com> <1286515292-15882-8-git-send-email-david@fromorbit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Dave Chinner Return-path: Received: from canuck.infradead.org ([134.117.69.58]:54906 "EHLO canuck.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753111Ab0JHHVU (ORCPT ); Fri, 8 Oct 2010 03:21:20 -0400 Content-Disposition: inline In-Reply-To: <1286515292-15882-8-git-send-email-david@fromorbit.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Oct 08, 2010 at 04:21:21PM +1100, Dave Chinner wrote: > From: Dave Chinner > > Direct modification of the inode reference count is a no-no. Convert > the exofs decrements to call iput() instead of acting directly on > i_count. Looks good, Reviewed-by: Christoph Hellwig The real question is why exofs got along with this so long.