From: Jan Kara Subject: Re: [PATCH] quota: fix dquot_disable vs dquot_trasnfer race v2 Date: Mon, 11 Oct 2010 15:33:31 +0200 Message-ID: <20101011133328.GA3830@quack.suse.cz> References: <87mxqno0c7.fsf@dmon-lap.sw.ru> <87hbgvnqbs.fsf@dmon-lap.sw.ru> <87eibznpnx.fsf@dmon-lap.sw.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jack@suse.cz, linux-fsdevel@vger.kernel.org To: Dmitry Return-path: Received: from cantor2.suse.de ([195.135.220.15]:47116 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754548Ab0JKNee (ORCPT ); Mon, 11 Oct 2010 09:34:34 -0400 Content-Disposition: inline In-Reply-To: <87eibznpnx.fsf@dmon-lap.sw.ru> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat 09-10-10 23:15:30, Dmitry wrote: > > I've got following lockup: > dquot_disable dquot_transfer > ->dqget() > sb_has_quota_active > dqopt->flags &= ~dquot_state_flag(f, cnt) atomic_inc(dq->dq_count) > ->drop_dquot_ref(sb, cnt); > down_write(dqptr_sem) > inode->i_dquot[cnt] = NULL ->__dquot_transfer > invalidate_dquots(sb, cnt); down_write(&dqptr_sem) > ->wait for dq_wait_unused inode->i_dquot = new_dquot > /* wait forever */ ^^^^New quota user^^^^^^ > > Inodes was already cleaned from quotas, and we can not allow new ones. > We have to recheck quota state under dqptr_sem and before assignment, > as we do it in dquot_initialize() Thanks. Merged into my tree. Honza -- Jan Kara SUSE Labs, CR