From: Mike Frysinger Date: Tue, 12 Oct 2010 15:26:15 -0400 Subject: [U-Boot] [PATCH 1/3] nand: allow demand initialization In-Reply-To: <20101011162733.7410b886@udp111988uds.am.freescale.net> References: <1286707060-7033-1-git-send-email-vapier@gentoo.org> <201010111702.01571.vapier@gentoo.org> <20101011162733.7410b886@udp111988uds.am.freescale.net> Message-ID: <201010121526.16608.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, October 11, 2010 17:27:33 Scott Wood wrote: > On Mon, 11 Oct 2010 17:02:00 -0400 Mike Frysinger wrote: > > On Monday, October 11, 2010 16:29:41 Scott Wood wrote: > > > On Sun, Oct 10, 2010 at 06:37:40AM -0400, Mike Frysinger wrote: > > > > --- a/common/cmd_nand.c > > > > +++ b/common/cmd_nand.c > > > > @@ -309,6 +309,8 @@ > > > > > > > > if (argc < 2) > > > > > > > > goto usage; > > > > > > > > + nand_init(); > > > > + > > > > > > Also do_nandboot(). > > > > does it need to be before the mtdparts init stuff, or can it be in > > nand_load_image() ? > > I think before -- the mtdparts init checks whether an mtd device > actually exists. Though in that case, and also for things > like mtdparts.spread, nand_init() should go in mtdparts_init(), and also > nand_load_image() in case mtdparts aren't enabled. np > OTOH, I'm fine with leaving that as a future refinement for someone who > is using embedded-env with NAND and cares about the boot time it adds. i'd lean towards this too. i have no way of testing this behavior. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20101012/136334ac/attachment.pgp