From: Wolfgang Denk Date: Tue, 12 Oct 2010 21:41:46 +0200 Subject: [U-Boot] [PATCH] - Add support for HP Jornada (710/720/728) board In-Reply-To: <20101006194103.GE896@boggieman.bredbandsbolaget.se> References: <20101006194103.GE896@boggieman.bredbandsbolaget.se> Message-ID: <20101012194146.BC24C1365CD@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Kristoffer Ericson, In message <20101006194103.GE896@boggieman.bredbandsbolaget.se> you wrote: > > Content-Type: text/plain; charset=utf-8 > Content-Disposition: inline > > This patch add support for the HP Jornada 700-series with flashrom (manufact. 2008). > With little effort it could also be made to support earlier flashroms (just a change of memory settings). > The HP Jornada is an strongarm device (sa1110 + sa1111). > > Signed-off-by: Kristoffer Ericson Please send as plain text. Use git tools to prepare ("git format-patch") and to submit ("git send-email") the patch. In any case, please make sure that commit message, Signed-off-by line and body of the patch are not split into separate MIME parts. Entry to MAINTAINERS file missing. ... > +int board_init(void) > +{ > + gd->bd->bi_arch_number = 48; > + gd->bd->bi_boot_params = 0xc0000100; > + > + > + /* turn on flashing > + * would be nice to have some protection but > + * that would have to be implemented in the > + * flash init function, which isnt possible yet. */ Incorrect multiline comment style. Please fix globally. ... > +#define CONFIG_BOOTARGS "root=/dev/hda1 console=ttySA0,19200n8 console=tty1" > +#define CONFIG_BOOTCOMMAND "run boot_kernel" > +#define CONFIG_SYS_AUTOLOAD "n" /* No autoload */ > +#define CONFIG_SYS_LOAD_ADDR 0xc0000000 > + > +/* > + * Miscellaneous configurable options > + */ > +#define CONFIG_SYS_LONGHELP /* undef to save memory */ > +#define CONFIG_SYS_PROMPT "HP Jornada# " /* Monitor Command Prompt */ > +#define CONFIG_SYS_CBSIZE 256 /* Console I/O Buffer Size */ > +#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)/* Print Buffer Size */ > +#define CONFIG_SYS_MAXARGS 16 /* max number of command args */ > +#define CONFIG_SYS_BARGSIZE 256 /* Boot Argument Buffer Size */ > +#define CONFIG_SYS_MEMTEST_START 0xc0040000 /* memtest works on */ > +#define CONFIG_SYS_MEMTEST_END 0xc2000000 /* 4 ... 128 MB in SDRAM */ > +#define CONFIG_SYS_HZ 3686400 /* incrementer freq: 3.6864 MHz */ > +#define CONFIG_SYS_CPUSPEED 0x0a /* set core clock to 206MHz */ > +#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } /* valid baudrates */ Lines too long. Please fix globally. Please clean up and resubmit. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Never underestimate the bandwidth of a station wagon full of tapes. -- Dr. Warren Jackson, Director, UTCS