From: Wolfgang Denk Date: Wed, 13 Oct 2010 19:41:58 +0200 Subject: [U-Boot] [PATCH] Disable unused chip-select for DDR controller interleaving In-Reply-To: <1286988197.5737.6.camel@oslab-l1> References: <1286983650-3911-1-git-send-email-yorksun@freescale.com> <20101013162407.4562A1365CC@gemini.denx.de> <1286988197.5737.6.camel@oslab-l1> Message-ID: <20101013174158.B12581365CC@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear York Sun, In message <1286988197.5737.6.camel@oslab-l1> you wrote: > > > Would it not be helpful to inform the user that we disabled a memory > > bank? Eventually this wa snot intentional... > > I can add a message but maybe not necessary. The only case the CS left > disable is the incomplete interleaving. For example the controller > interleaving is enabled, but the bank interleaving is disabled or less > than all populated CS are interleaving. In these cases, the unused CSs > (or maybe CS'es, my bad English) are not accessible, even enabled. This > patch doesn't change the hardware behavior, but to disable those unused > CS to avoid confusion. I understand this. But I think the conditions that cause such behaviour are pretty unusual, and most probably not something that is actually intended by the end user - for example, he might have installed an incompatible DIMM or such. It would be nice if he was made aware that somthing unusual is going on, so he can double-check his configuration. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de 2000 pounds of chinese soup = 1 Won Ton