From: Mark Brown Subject: Re: [patch 3/3] t5325: add audio support Date: Wed, 13 Oct 2010 19:06:08 +0100 Message-ID: <20101013180607.GA15001@sirena.org.uk> References: <20101012094453.660938870@rtp-net.org> <20101012100039.492443712@rtp-net.org> <20101012171845.GI30933@rakim.wolfsonmicro.main> <87wrpmvunr.fsf@lechat.rtp-net.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id 9312D103971 for ; Wed, 13 Oct 2010 20:06:10 +0200 (CEST) Content-Disposition: inline In-Reply-To: <87wrpmvunr.fsf@lechat.rtp-net.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Arnaud Patard Cc: alsa-devel@alsa-project.org, Liam Girdwood , Saeed Bishara , Martin Michlmayr List-Id: alsa-devel@alsa-project.org On Wed, Oct 13, 2010 at 08:01:44PM +0200, Arnaud Patard wrote: > Mark Brown writes: > > On Tue, Oct 12, 2010 at 11:44:56AM +0200, Arnaud Patard wrote: > >> This patch declares the i2c audio codec and initialise audio. > > Looks like the changelogs for this and the previous patch got > > transposed > It's bad wording then. For me the changelog is fine. It means that : > - it's adding the alc5621 codec in the i2c bard info > - initialise kirkwood audio stuff by calling kirkwood_audio_init(). > Maybe putting the explanations above would be better ? Oh, actually the problem is that you've not prefixed the ASoC patches with ASoC: so they look like they're supposed to be arch/arm patches (2/3 being the main offender).