From: Wolfgang Denk Date: Sun, 17 Oct 2010 16:06:40 +0200 Subject: [U-Boot] [PATCH V2 1/1] IMX: rename mx51 to mx5 In-Reply-To: <3850A844E6A3854C827AC5C0BEC7B60A2B0596@zch01exm23.fsl.freescale.net> References: <1287155158-16801-1-git-send-email-r64343@freescale.com> <20101015190813.C6D821365CF@gemini.denx.de> <3850A844E6A3854C827AC5C0BEC7B60A2B0596@zch01exm23.fsl.freescale.net> Message-ID: <20101017140640.5088613558AD@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Liu Hui-R64343, In message <3850A844E6A3854C827AC5C0BEC7B60A2B0596@zch01exm23.fsl.freescale.net> you wrote: > > > I suggest we do the same. Please add a "mx5" resp. "MX5" to the new > > identifier names. > > Yes, agree. Thanks. > > Please also keep in mind that CONFIG_* options should be documented in > > the README. > > Do you mean all the specific CONFIG_* options in > include/configs/boardname.h should be documented? > I found lots of that is not doing what you called for? :( Yes, we have not always been that strict, but we try to improve. > BTW, which definition is better? > > CONFIG_SYS_MX5_HCLK_FREQ 24000000 > CONFIG_MX5_HCLK_FREQ 24000000 > > According to the REAME, I prefer to the former, what do you think. Indeed CONFIG_SYS_* seems more appropriate here. I would probably call this "CONFIG_SYS_MX5_HCLK" ("CLK" and "FREQ" seem a bit redundant here). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Some programming languages manage to absorb change, but withstand progress. -- Epigrams in Programming, ACM SIGPLAN Sept. 1982