From: Tim Deegan Subject: Re: [PATCH 00/18] xenpaging changes for 4.0 Date: Mon, 18 Oct 2010 12:26:01 +0100 Message-ID: <20101018112601.GP4007@whitby.uk.xensource.com> References: <20101015141202.309585877@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Return-path: Content-Disposition: inline In-Reply-To: <20101015141202.309585877@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Olaf Hering Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Hi Olaf, Thanks for all your work on this! These patches look pretty good to me, with a few caveats: - Is it possible to avoid having quite so many paths return ENOENT? In particular, there seemed to be paths where _removing_ a p2m entry that's paged out caused an error. Would it be possible to have some of those cases fixed up from the paging code instead? - The usual way to get patches into the 4.0 tree is to submit them againts xen-unstable and then ask for specific patches to be backported; I see you're already going that way with most of these. - I imagine the tools maintainers will encourage you to do your tools patches againsl xl/libxl as well. :) Cheers, Tim. At 15:12 +0100 on 15 Oct (1287155522), Olaf Hering wrote: > Here are some changes for xenpaging in the 4.0 branch. > > Its just for review and comments. All changes are also needed for > xen-unstable, I will prepare a patch queue also for this branch. > > There are still issues with xenpaging. > My testsetup is a SLES11 SP1 guest with runlevel 6 as default runlevel to > trigger automatic reboot. After a few iterations, there will be MMIO emulation > errors. This happens with a startup delay of 15.0 seconds. > > Another issue: > If the startup delay is 0.0, and over_allocated in hvmloader mem_alloc is > forced to be active, the ASSERT in p2m_remove_page() triggers. This is because > the passed mfn and the mfn returned by ->get_entry() do not match. So far I > have no idea where the appearently missing set_gpfn_from_mfn() should go to. > Normally over_allocated is not set because the XENMEM_populate_physmap call > does not fail. > > Olaf > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel -- Tim Deegan Principal Software Engineer, XenServer Engineering Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)