From: Wolfgang Denk Date: Thu, 21 Oct 2010 20:06:45 +0200 Subject: [U-Boot] [PATCH] mainline arm926ejs: Fix two occurrences of illegal syntax assembler instructions In-Reply-To: <4CC06B1A.2070401@rocketmail.com> References: <4CC06B1A.2070401@rocketmail.com> Message-ID: <20101021180645.C2244136320@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Gray Remlin, In message <4CC06B1A.2070401@rocketmail.com> you wrote: > HEAD is at commit c62491d2602b353a815a909e27eec0df9f2c06a2 > Untested due to link error bug What makes you think this is "illegal syntax" ? gas seems to digest this just fine. Which sort of tool chain are you using? > --- > arch/arm/cpu/arm926ejs/start.S | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Hm, if you really want to fix this, then please fix all occurrences: -> find arch/arm | xargs grep 'add r[0-9], r[0-9][^,]*$' arch/arm/cpu/arm1136/start.S: add r0, r9 /* r0 <- location to fix up in RAM */ arch/arm/cpu/arm1136/start.S: add r1, r9 /* r1 <- relocated sym addr */ arch/arm/cpu/arm926ejs/start.S: add r0, r9 /* r0 <- location to fix up in RAM */ arch/arm/cpu/arm926ejs/start.S: add r1, r9 /* r1 <- relocated sym addr */ arch/arm/cpu/armv7/start.S: add r0, r9 /* r0 <- location to fix up in RAM */ arch/arm/cpu/armv7/start.S: add r1, r9 /* r1 <- relocated sym addr */ Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de If all you have is a hammer, everything looks like a nail.