From: Wolfgang Denk Date: Thu, 21 Oct 2010 22:46:26 +0200 Subject: [U-Boot] [PATCH] net: Add labels to endifs and remove impossible conditional code block In-Reply-To: <4CC0A479.4040900@emk-elektronik.de> References: <4CC09695.6070702@rocketmail.com> <20101021202257.DF79A1359B7@gemini.denx.de> <4CC0A479.4040900@emk-elektronik.de> Message-ID: <20101021204626.90DFE1359B7@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Reinhard Meyer, In message <4CC0A479.4040900@emk-elektronik.de> you wrote: > > >> -#if defined(CONFIG_CMD_DHCP) > >> - *e++ = 53; /* DHCP Message Type */ > >> - *e++ = 1; > >> - *e++ = DHCP_DISCOVER; > >> - > >> - *e++ = 57; /* Maximum DHCP Message Size */ > >> - *e++ = 2; > >> - *e++ = (576 - 312 + OPT_SIZE)>> 16; > >> - *e++ = (576 - 312 + OPT_SIZE)& 0xff; > >> -#endif > > > > What makes you think CONFIG_CMD_DHCP was never used? There are 270+ > > boards that use this! > > Its in the ELSE part like this: Ouch. > #if defined(CONFIG_CMD_DHCP) > ... > #else > ... > #if defined(CONFIG_CMD_DHCP) > ... > #endif > ... > #endif > > Perhaps it should be investigated how it happened to become such dead code? Indeed. This cannot be right / intentional. Just deleting it seems wrong in any case. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de People are very flexible and learn to adjust to strange surroundings -- they can become accustomed to read Lisp and Fortran programs, for example. - Leon Sterling and Ehud Shapiro, Art of Prolog, MIT Press