From: cjb@laptop.org (Chris Ball) Date: Fri, 22 Oct 2010 12:04:57 +0100 Subject: [PATCH V3 1/1]MMC: add support of sdhci-pxa driver In-Reply-To: <20101022095814.GA13073@void.printf.net> References: <20101021141302.GA11912@void.printf.net> <20101021145249.GA13095@void.printf.net> <20101022095814.GA13073@void.printf.net> Message-ID: <20101022110457.GA14136@void.printf.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Fri, Oct 22, 2010 at 10:58:14AM +0100, Chris Ball wrote: [...] > +#ifdef CONFIG_PM > +static int sdhci_pxa_suspend(struct platform_device *dev) > +{ > + struct sdhci_host *host = platform_get_drvdata(to_platform_device(dev)); > + > + return sdhci_suspend_host(host, state); > +} > + > +static int sdhci_pxa_resume(struct platform_device *dev) > +{ These prototypes are not correct, leading to: CC [M] drivers/mmc/host/sdhci-pxa.o drivers/mmc/host/sdhci-pxa.c: In function ?sdhci_pxa_suspend?: drivers/mmc/host/sdhci-pxa.c:205: warning: initialization from incompatible pointer type drivers/mmc/host/sdhci-pxa.c:207: error: ?state? undeclared (first use in this function) drivers/mmc/host/sdhci-pxa.c:207: error: (Each undeclared identifier is reported only once drivers/mmc/host/sdhci-pxa.c:207: error: for each function it appears in.) drivers/mmc/host/sdhci-pxa.c: In function ?sdhci_pxa_resume?: drivers/mmc/host/sdhci-pxa.c:212: warning: initialization from incompatible pointer type drivers/mmc/host/sdhci-pxa.c: At top level: drivers/mmc/host/sdhci-pxa.c:222: warning: initialization from incompatible pointer type drivers/mmc/host/sdhci-pxa.c:223: warning: initialization from incompatible pointer type when compiled with CONFIG_PM=y. -- Chris Ball One Laptop Per Child