From: Wolfgang Denk Date: Tue, 26 Oct 2010 18:26:58 +0200 Subject: [U-Boot] Timer implementations In-Reply-To: <4CC6F23A.2040608@ti.com> References: <1288054924-24989-1-git-send-email-nm@ti.com> <4CC62B6C.30601@emk-elektronik.de> <20101026052856.3D467152451@gemini.denx.de> <4CC66A67.4000608@emk-elektronik.de> <20101026054812.60816135DE3@gemini.denx.de> <4CC66ECA.9000106@emk-elektronik.de> <4CC67CA1.9090302@emk-elektronik.de> <20101026074132.8013C152451@gemini.denx.de> <4CC68A07.6050109@emk-elektronik.de> <4CC6EFB1.9000701@ti.com> <20101026151748.619481365DB@gemini.denx.de> <4CC6F23A.2040608@ti.com> Message-ID: <20101026162658.8FD71152451@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Nishanth Menon, In message <4CC6F23A.2040608@ti.com> you wrote: > > > No. This code is always wrong. Please fix it as described. > Apologies on being a dudhead, I suppose you mean the following: > > ulong start; > start = get_timer(0); > while (!(readl(&mmc_base->stat) & CC_MASK)) { > if (get_timer(start) > usec2ticks(MAX_RETRY_US)) { > printf("%s: timedout waiting for cc2!\n", __func__); > return; > } > } > > would this be better? No, not at all, as get_timer() returns milliseconds, not ticks. You probably want something like: ulong start = get_timer(0); while (!(readl(&mmc_base->stat) & CC_MASK)) { if (get_timer(0) - start >= MAX_RETRY_US/1000) { printf(...); return; } udelay(100); } or such. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de He had quite a powerful intellect, but it was as powerful like a locomotive, and ran on rails and was therefore almost impossible to steer. - Terry Pratchett, _Lords and Ladies_