From: Peter Stuge Date: Fri, 29 Oct 2010 07:12:43 +0200 Subject: [ath9k-devel] [PATCH] ath9k: Clear DMA addresses when buffers are freed. In-Reply-To: <20101028233636.GB2985@tux> References: <1287178199-7506-1-git-send-email-greearb@candelatech.com> <4CCA0848.7080001@candelatech.com> <20101028233636.GB2985@tux> Message-ID: <20101029051243.4171.qmail@stuge.se> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Luis R. Rodriguez wrote: > On Thu, Oct 28, 2010 at 04:33:28PM -0700, Ben Greear wrote: > > > From: Ben Greear > > > > > > Previous patches cleared the pointer to the SKB, but did not > > > clear the DMA addresses. This patch moves the clear logic into > > > a method and makes sure that the DMA addresses are cleared as well. > > > > > > This does not obviously fix any bug, but may make it harder to > > > cause bugs in the future. > > > > I wanted to follow up to see if there was any interest in this patch, > > as it received no comment and has not been accepted upstream. Acked-by: Peter Stuge > I'd rather not introduce code unless you know > for sure its doing something useful. Cleaning up messy and/or redundant code is extremely useful. //Peter