From: Jeremy Kerr Date: Fri, 05 Nov 2010 13:08:49 +0000 Subject: Re: [Cbe-oss-dev] [PATCH 03/49] arch/powerpc: Use vzalloc Message-Id: <201011050908.50190.jk@ozlabs.org> List-Id: References: <5da00d7f95b5c7a96fbfa8420f5e3a8ef33e01e6.1288925424.git.joe@perches.com> In-Reply-To: <5da00d7f95b5c7a96fbfa8420f5e3a8ef33e01e6.1288925424.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cbe-oss-dev@lists.ozlabs.org Cc: Joe Perches , Jiri Kosina , kvm@vger.kernel.org, Arnd Bergmann , Marcelo Tosatti , Alexander Graf , kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Avi Kivity Hi Joe, > diff --git a/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c > b/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c index a101abf..3b894f5 > 100644 > --- a/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c > +++ b/arch/powerpc/platforms/cell/spufs/lscsa_alloc.c > @@ -36,10 +36,9 @@ static int spu_alloc_lscsa_std(struct spu_state *csa) > struct spu_lscsa *lscsa; > unsigned char *p; > > - lscsa = vmalloc(sizeof(struct spu_lscsa)); > + lscsa = vzalloc(sizeof(struct spu_lscsa)); > if (!lscsa) > return -ENOMEM; > - memset(lscsa, 0, sizeof(struct spu_lscsa)); > csa->lscsa = lscsa; > > /* Set LS pages reserved to allow for user-space mapping. */ For the spufs bit: Acked-By: Jeremy Kerr Cheers, Jeremy