Received: from [140.186.70.92] (port=44286 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PEULk-0007wT-SX for qemu-devel@nongnu.org; Fri, 05 Nov 2010 18:01:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PEULj-0002sv-OZ for qemu-devel@nongnu.org; Fri, 05 Nov 2010 18:01:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PEULj-0002sc-Hw for qemu-devel@nongnu.org; Fri, 05 Nov 2010 18:01:31 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oA5M1UAX020538 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 5 Nov 2010 18:01:30 -0400 From: Alex Williamson Date: Fri, 05 Nov 2010 16:01:29 -0600 Message-ID: <20101105220128.26044.11658.stgit@s20.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH RESEND] apic: Don't iterate past last used apic List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com local_apics are allocated sequentially and never removed, so we can stop any iterations that go to MAX_APICS as soon as we hit the first NULL. Looking at a small guest running a virtio-net workload with oprofile, this drops apic_get_delivery_bitmask() from #3 in the profile to down in the noise. Signed-off-by: Alex Williamson --- hw/apic.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/apic.c b/hw/apic.c index 63d62c7..5f4a87c 100644 --- a/hw/apic.c +++ b/hw/apic.c @@ -437,6 +437,8 @@ static int apic_find_dest(uint8_t dest) apic = local_apics[i]; if (apic && apic->id == dest) return i; + if (!apic) + break; } return -1; @@ -472,6 +474,8 @@ static void apic_get_delivery_bitmask(uint32_t *deliver_bitmask, set_bit(deliver_bitmask, i); } } + } else { + break; } } }