From: Charles Manning Subject: Re: [PATCH 1/9] Add yaffs Kconfig and Makefile Date: Mon, 8 Nov 2010 11:22:36 +1300 Message-ID: <201011081122.37145.manningc2@actrix.gen.nz> References: <1288803204-3849-1-git-send-email-cdhmanning@gmail.com> <201011080959.35220.manningc2@actrix.gen.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Valdis.Kletnieks@vt.edu, cdhmanning@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Chris Snook Return-path: Received: from smtp.scorch.co.nz ([27.110.127.199]:45443 "HELO scorch.co.nz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1751727Ab0KGWWk convert rfc822-to-8bit (ORCPT ); Sun, 7 Nov 2010 17:22:40 -0500 In-Reply-To: Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Monday 08 November 2010 10:45:32 Chris Snook wrote: > On Sun, Nov 7, 2010 at 4:59 PM, Charles Manning =20 wrote: > > On Saturday 06 November 2010 14:50:58 Valdis.Kletnieks@vt.edu wrote= : > >> On Thu, 04 Nov 2010 05:53:16 +1300, cdhmanning@gmail.com said: > >> > From: Charles Manning > >> > +config YAFFS_EMPTY_LOST_AND_FOUND > >> > + =A0 bool "Empty lost and found on boot" > >> > + =A0 depends on YAFFS_FS > >> > + =A0 default n > >> > + =A0 help > >> > + =A0 =A0 If this is enabled then the contents of lost and found= is > >> > + =A0 =A0 automatically dumped at mount. > >> > >> Wow.. Just.. wow. > > > > What does that mean? > > > >> Under what use case is this a good idea for a config > >> option as opposed to a mount option? > > > > It is both. > > > > Providing a config option provides the system integrator with flexi= bility > > in how they set things up. > > Does the config option override the mount option, or does the mount > option override the config option?=20 Config sets up a default, mount options can override those. > No matter what you do, someone=20 > will be surprised, and that's a bad thing. I'm having difficulty > imagining a circumstance when you couldn't simply do this in userspac= e > immediately after mount, but if for whatever reason you need > mount+dump to be an atomic operation, Sure it could be done in user space, but it is easier to handle this in= the=20 mount. > it *really* should not be=20 > polluting the kernel configuration. Perhaps just make it a mount option. > > There are a whole bunch of options in here that appear to be intended > to support various different stages of development. Is there some > reason why you can't call that mess of permutations YAFFS1, and merge > a clean YAFFS2 patch that doesn't depend on it?=20 You seem to misunderstand what YAFFS1 and YAFFS2 are. Your point is well taken though. Many of these options are "tweaks" tha= t could=20 be dropped form Kconfig and only offered as mount options. > I know that you're=20 > trying to support multiple operating systems with the same codebase, > but once your code is merged it will get patched by other people > making kernel-wide changes, and testing (or even eyeballing) all thos= e > permutations will be far outside the realm of feasibility. To be clear: none of the Kconfig options relate to other OS support. It is my intention to continue to support other OSs and backporting + n= ew=20 features though yaffs.net and patch those into mainstream. While some f= uture=20 changes might make this infeasible, I'll cross that bridge when we get = to it. =20 I'm not going to give up yet. -- Charles -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html