From: Simon Horman Subject: Re: [v2 PATCH 0/4] IPVS: Backup Adding Ipv6 and Persistence support Date: Tue, 9 Nov 2010 09:39:11 +0900 Message-ID: <20101109003911.GH6502@verge.net.au> References: <201010291415.35299.hans.schillstrom@ericsson.com> <201011081615.11335.hans.schillstrom@ericsson.com> <20101108220029.GD6502@verge.net.au> <201011082323.26313.hans@schillstrom.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <201011082323.26313.hans@schillstrom.com> Sender: lvs-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hans Schillstrom Cc: Hans Schillstrom , Julian Anastasov , LVS-Devel , "wensong@linux-vs.org" , "daniel.lezcano@free.fr" On Mon, Nov 08, 2010 at 11:23:25PM +0100, Hans Schillstrom wrote: > > On Monday, November 08, 2010 23:00:29 Simon Horman wrote: > > On Mon, Nov 08, 2010 at 04:15:10PM +0100, Hans Schillstrom wrote: > > > On Monday 08 November 2010 07:21:23 Simon Horman wrote: > > > [ snip ] > > > > > > > How about this, which applies on top of > > > > "IPVS: Add persistence engine to connection entry". > > > > > > > > From: Simon Horman > > > > Subject: IPVS: Only match pe_data created by the same pe > > > > > > > > Only match persistence engine data if it was > > > > created by the same persistence engine. > > > > > > > > Reported-by: Julian Anastasov > > > > Signed-off-by: Simon Horman > > > > > > Thanks I'll will use that one, > > > I think it's time to cook a new backup patch, > > > or do any one have more patches in the pipe ? > > > > I have added this and the other patches that I am completely happy with > > to the staging branch of lvs-test-2.6. > > > > Specifically the patches in there are: > > > > * IPVS: Only match pe_data created by the same pe > > * IPVS: Add persistence engine to connection entry > > * IPVS: Backup, Adding structs for new sync format > > * IPVS: Prepare for transferring firewall marks (fwmark) to the backup daemon. > > * IPVS: ip_vs_pe.c, use strncmp to be safe. > > > > If you are unhappy with any of those changes let me know, > > I'm happy to revert and rebase the staging branch > > (its mainly for your benefit at this stage). > > Thanks a lot, > I will start with the cooking tomorrow, with lvs-test-2.6 as my base Be sure to use the staging branch :-) > > I would also like to add the following clean-up changes, > > could I get an Ack or Nack from you on each of them? > > > > * IPVS: Make the cp argument to ip_vs_sync_conn() static > > http://www.spinics.net/lists/lvs-devel/msg01375.html > ACK, > I'll do the same in the last patch for _v0/_v1 sending > > > * IPVS: Remove useless { } block from ip_vs_process_message() > > http://www.spinics.net/lists/lvs-devel/msg01369.html > ACK, > > > * IPVS: buffer argument to ip_vs_process_message() should not be const > > http://www.spinics.net/lists/lvs-devel/msg01377.html > > > ACK Thanks.