From: Mike Frysinger Date: Tue, 9 Nov 2010 09:38:20 -0500 Subject: [U-Boot] [PATCH 1/2] use MAC from environment and add support for new NET_MULTI api in ethernet driver of KS8695 In-Reply-To: References: Message-ID: <201011090938.20821.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday, November 04, 2010 06:13:00 Bernstein, Michael wrote: > diff --unified --recursive --new-file > u-boot-2009.11/drivers/net/ks8695eth.c > u-boot-2009.11,new/drivers/net/ks8695eth.c --- > u-boot-2009.11/drivers/net/ks8695eth.c this is a pretty old tree. you should be using latest mainline tree. > void ks8695_getmac(void) > { > - unsigned char *fp; > - int i; > + if (!eth_getenv_enetaddr("ethaddr", ð_mac[0])) { NAK. drivers should not be poking the environment. please read the documentation in doc/README.drivers.eth. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20101109/1c617b25/attachment.pgp