From: Markus Trippelsdorf Subject: Re: Radeon RS780 - BUG: unable to handle kernel NULL pointer dereference Date: Tue, 9 Nov 2010 11:37:37 +0100 Message-ID: <20101109103737.GA1767@arch.trippelsdorf.de> References: <20101108170221.GA1602@arch.trippelsdorf.de> <20101108170737.GA1617@arch.trippelsdorf.de> <20101108184301.GA1614@arch.trippelsdorf.de> <20101108190258.GA1623@arch.trippelsdorf.de> <4CD879BC.5060008@vmware.com> <20101109092920.GA1542@arch.trippelsdorf.de> <4CD91A07.1060308@vmware.com> <4CD91D58.7080508@vmware.com> <1289298777.10682.63.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from smtp-out-105.synserver.de (smtp-out-105.synserver.de [212.40.180.105]) by gabe.freedesktop.org (Postfix) with SMTP id 058119E9E5 for ; Tue, 9 Nov 2010 02:37:42 -0800 (PST) Content-Disposition: inline In-Reply-To: <1289298777.10682.63.camel@thor.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Michel =?iso-8859-1?Q?D=E4nzer?= Cc: Thomas Hellstrom , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org On Tue, Nov 09, 2010 at 11:32:57AM +0100, Michel D=E4nzer wrote: > On Die, 2010-11-09 at 11:07 +0100, Thomas Hellstrom wrote: = > > On 11/09/2010 10:53 AM, Thomas Hellstrom wrote: > > > On 11/09/2010 10:29 AM, Markus Trippelsdorf wrote: > > >> OK I've found the buggy commit by bisection: > > >> > > >> e376573f7267390f4e1bdc552564b6fb913bce76 is the first bad commit > > >> commit e376573f7267390f4e1bdc552564b6fb913bce76 > > >> Author: Michel D=E4nzer > > >> Date: Thu Jul 8 12:43:28 2010 +1000 > > >> > > >> drm/radeon: fall back to GTT if bo creation/validation in VRAM = > > >> fails. > > >> > > >> This fixes a problem where on low VRAM cards we'd run out of = > > >> space for validation. > > >> > > >> [airlied: Tested on my M7, Thinkpad T42, compiz works with no = > > >> problems.] > > >> > > >> Signed-off-by: Michel D=E4nzer > > >> Cc: stable@kernel.org > > >> Signed-off-by: Dave Airlie > > >> > > >> Please note that this is an old commit from 2.6.36-rc. When I revert = > > >> it the > > >> kernel no longer crashes. Instead I see the following in my dmesg: > > >> > > > > > > Hmm, so this sounds like something in the Radeon eviction error path = > > > is causing corruption. > > > I had a similar problem with vmwgfx, when I tried to unref a BO = > > > _after_ ttm_bo_init() failed. > > > ttm_bo_init() is really supposed to call unref itself for various = > > > reasons, so calling unref() or kfree() after a failed ttm_bo_init() = > > > will cause corruption. > > > > > > In any case, the error below also suggests something is a bit fragile = > > > in the Radeon driver: > > > > > > First, an accelerated eviction may fail, like in the message below, = > > > but then there must always be a backup plan, like unaccelerated = > > > eviction to system. On BO creation, there are a number of placement = > > > strategies, but if all else fails, it should be possible to initially = > > > place the BO in system memory. > > > > > > Second, If bo validation fails during a command submission, due to = > > > insufficient VRAM / TT, then the driver should retry the complete = > > > validation cycle after first blocking all other validators and then = > > > evicting everything not pinned, to avoid failures due to fragmentatio= n. > > > > > > /Thomas > > > > > = > > Indeed, it seems like the commit you mention just retries ttm_bo_init() = > > after it previously failed. At that point the bo has been destroyed, so = > > that is probably what's causing the BUG you are seeing. > > = > > Admittedly, ttm_bo_init() calling unref on failure is not properly = > > documented in the function description. The reason for doing so is to = > > have a single path for freeing all BO resources already allocated on th= e = > > point of failure. > = > Does the patch below fix the problem? Yes, indeed. I was just about to send the same patch to the list. Thanks. -- = Markus