From: Wolfgang Denk Date: Sun, 14 Nov 2010 22:49:23 +0100 Subject: [U-Boot] [PATCH] support for 2 DRAM banks and FLASH bank with 16MB in KS8695 In-Reply-To: References: Message-ID: <20101114214923.2DD38134FEF@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear "Bernstein, Michael", In message you wrote: > > The patch attached add support for a flash bank size of 16 MB and for a second DRAM bank for the KS8695 (ARM9 core) depending on the configuration. > > A better solution would be to calculate the values for the registers (only some shifts are needed) but this was the lazy implementation. Please restrict the line length in the commit message to 70 characters or less. > I hope, I don't make to much mistakes in the presentation of my patch because it is the first patch I publish to this list. Sadly I don't have access to the development PC any more because it was a project for a subsidiary co> mpany and I finished the project at end of September. Such comments should not be part of the commit message, so please move this into the comment section. Please see http://www.denx.de/wiki/view/U-Boot/Patches#Commit_message_conventions and http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Computers are not intelligent. They only think they are.