From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 2/3] xen: add CPU microcode update driver Date: Mon, 15 Nov 2010 10:59:28 -0500 Message-ID: <20101115155928.GC345@dumpdata.com> References: <37a80bdde5957ffa81c2ecdffc4ccc2e874e34cb.1289519130.git.jeremy.fitzhardinge@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <37a80bdde5957ffa81c2ecdffc4ccc2e874e34cb.1289519130.git.jeremy.fitzhardinge@citrix.com> Sender: linux-kernel-owner@vger.kernel.org To: Jeremy Fitzhardinge Cc: "H. Peter Anvin" , Linux Kernel Mailing List , Xen-devel , the arch/x86 maintainers , Jeremy Fitzhardinge List-Id: xen-devel@lists.xenproject.org > +static enum ucode_state xen_request_microcode_user(int cpu, > + const void __user *buf, size_t size) > +{ > + struct ucode_cpu_info *uci = ucode_cpu_info + cpu; > + struct xen_microcode *uc; > + enum ucode_state ret; > + size_t unread; > + > + if (cpu != 0) { > + /* No real firmware for non-zero cpus; just store a > + placeholder */ > + size = 0; > + } > + > + if (uci->mc != NULL) { > + vfree(uci->mc); > + uci->mc = NULL; > + } > + > + ret = UCODE_ERROR; > + uc = vmalloc(sizeof(*uc) + size); > + if (uc == NULL) > + goto out; > + > + uc->len = size; > + > + ret = UCODE_NFOUND; > + > + /* XXX This sporadically returns uncopied bytes, so we return > + EFAULT. As far as I can see, the usermode code ^^^^^ UCODE_NFOUND. > + (microcode_ctl) isn't doing anything wrong... */ Is this still valid? Looking at AMD it checks for a magic key and the Intel just copies without checks.