From: Joel Becker Date: Thu, 18 Nov 2010 15:45:27 -0800 Subject: [Ocfs2-devel] [PATCH] [OCFS2] ocfs2_connection_find() returns pointer to bad structure In-Reply-To: <1290117789-3915-1-git-send-email-dann.frazier@canonical.com> References: <1290117789-3915-1-git-send-email-dann.frazier@canonical.com> Message-ID: <20101118234527.GL19821@mail.oracle.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: dann frazier Cc: ocfs2-devel@oss.oracle.com, linux-kernel@vger.kernel.org On Thu, Nov 18, 2010 at 03:03:09PM -0700, dann frazier wrote: > If ocfs2_live_connection_list is empty, ocfs2_connection_find() will return > a pointer to the LIST_HEAD, cast as a ocfs2_live_connection. This can cause > an oops when ocfs2_control_send_down() dereferences c->oc_conn: > > Call Trace: > [] ocfs2_control_message+0x28c/0x2b0 [ocfs2_stack_user] > [] ocfs2_control_write+0x35/0xb0 [ocfs2_stack_user] > [] vfs_write+0xb8/0x1a0 > [] ? do_page_fault+0x153/0x3b0 > [] sys_write+0x51/0x80 > [] system_call_fastpath+0x16/0x1b > > Fix by explicitly returning NULL if no match is found. > > Signed-off-by: dann frazier This patch is now in the fixes branch of ocfs2.git. Joel -- "I don't even butter my bread; I consider that cooking." - Katherine Cebrian Joel Becker Senior Development Manager Oracle E-mail: joel.becker at oracle.com Phone: (650) 506-8127