Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1PKqRC-0008Nr-6D for mharc-grub-devel@gnu.org; Tue, 23 Nov 2010 05:49:26 -0500 Received: from [140.186.70.92] (port=46437 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKqR9-0008Ne-2z for grub-devel@gnu.org; Tue, 23 Nov 2010 05:49:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKqR8-0004Qa-4B for grub-devel@gnu.org; Tue, 23 Nov 2010 05:49:22 -0500 Received: from smarthost01.mail.zen.net.uk ([212.23.3.140]:44260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKqR7-0004QR-Ux for grub-devel@gnu.org; Tue, 23 Nov 2010 05:49:22 -0500 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost01.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1PKqR5-0001wW-Lf for grub-devel@gnu.org; Tue, 23 Nov 2010 10:49:19 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1PKqR5-0002aL-00; Tue, 23 Nov 2010 10:49:19 +0000 Date: Tue, 23 Nov 2010 10:49:18 +0000 From: Colin Watson To: grub-devel@gnu.org Message-ID: <20101123104918.GD21862@riva.ucam.org> References: <20101122233140.GC21862@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101122233140.GC21862@riva.ucam.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost01-IP: [82.69.40.219] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Fix GPT build failure on big-endian architectures X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2010 10:49:24 -0000 On Mon, Nov 22, 2010 at 11:31:40PM +0000, Colin Watson wrote: > @@ -198,6 +198,14 @@ static struct grub_partition_map grub_gp > GRUB_MOD_INIT(part_gpt) > { > grub_partition_map_register (&grub_gpt_partition_map); > +#ifdef GRUB_UTIL > + grub_gpt_partition_type_bios_boot.data1 = > + grub_cpu_to_le32 (grub_gpt_partition_type_bios_boot.data1); > + grub_gpt_partition_type_bios_boot.data2 = > + grub_cpu_to_le32 (grub_gpt_partition_type_bios_boot.data2); > + grub_gpt_partition_type_bios_boot.data3 = > + grub_cpu_to_le32 (grub_gpt_partition_type_bios_boot.data3); > +#endif > } > > GRUB_MOD_FINI(part_gpt) > Of course the second and third of these should have been grub_cpu_to_le16. I've gone ahead and applied this, with that correction; please do correct me if you notice anything else wrong with it. -- Colin Watson [cjwatson@ubuntu.com]