From: Mike Frysinger Date: Wed, 24 Nov 2010 16:57:15 -0500 Subject: [U-Boot] [PATCH] cmd_usage: Use ignored return value In-Reply-To: <1290602294-17230-1-git-send-email-weber@corscience.de> References: <1290602294-17230-1-git-send-email-weber@corscience.de> Message-ID: <201011241657.16708.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, November 24, 2010 07:38:14 Thomas Weber wrote: > cmd_usage returns 1, so its return value can be used as return value. your summary implies that "cmd_usage" is being changed when in reality, random commands are being changed to use cmd_usage. > arch/powerpc/cpu/ppc4xx/cmd_ecctest.c | 6 ++---- > board/gdsys/common/osd.c | 6 ++---- > common/cmd_nvedit.c | 18 ++++++------------ > 3 files changed, 10 insertions(+), 20 deletions(-) seems like these should be split up ... -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20101124/41fe7119/attachment.pgp