From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] x86/pvclock-xen: zero last_value on resume
Date: Fri, 26 Nov 2010 11:40:47 +0100
Message-ID: <20101126104047.GA9798@elte.hu>
References: <4CC708DE.1070000@goop.org>
 <4CEACFAB.90503@goop.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
	kvm-devel <kvm@vger.kernel.org>, Glauber Costa <glommer@redhat.com>,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Virtualization <virtualization@lists.linux-foundation.org>,
	Olivier Hanesse <olivier.hanesse@gmail.com>,
	Avi Kivity <avi@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>, Eelco Dolstra <e.dolstra@tudelft.nl>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <4CEACFAB.90503@goop.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
List-Id: kvm.vger.kernel.org


* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> On 10/26/2010 09:59 AM, Jeremy Fitzhardinge wrote:
> >
> > If the guest domain has been suspend/resumed or migrated, then the
> > system clock backing the pvclock clocksource may revert to a smaller
> > value (ie, can be non-monotonic across the migration/save-restore).
> > Make sure we zero last_value in that case so that the domain
> > continues to see clock updates.
> 
> Ping?  Looks like this fell through the gaps.

Does not apply cleanly here - mind resending the latest version?

Thanks,

	Ingo