From: Wolfgang Denk Date: Sun, 28 Nov 2010 21:35:58 +0100 Subject: [U-Boot] [PATCH V2 1/1] net: fix some bugs in LL TEMAC driver In-Reply-To: <1290419192-13422-2-git-send-email-linz@li-pro.net> References: <66901067543efe59d87b3a805a4b19ce52a780c5.1290192590.git.linz@li-pro.net> <1290419192-13422-1-git-send-email-linz@li-pro.net> <1290419192-13422-2-git-send-email-linz@li-pro.net> Message-ID: <20101128203558.035181352CD@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Stephan Linz, In message <1290419192-13422-2-git-send-email-linz@li-pro.net> you wrote: > * avoid using link variable uninitialized > * avoid using phy_addr variable with invalid value > * reorganize phy control: first looking for phy than link > * return with error (result value 0) if no phy/link was found > * fix boolean mistake in wait for link: wait as long as we got > phy register 1 has no link indication (BMSR != 0x24) > * expand the 'first run' flag handling in ll_temac_init() in > respect to possible error detection in xps_ll_temac_phy_ctrl() > > Signed-off-by: Stephan Linz > --- > drivers/net/xilinx_ll_temac.c | 52 ++++++++++++++++++++++++++++++----------- > 1 files changed, 38 insertions(+), 14 deletions(-) Please merges these fixzes into the next submission of the LL TEMAC driver. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de A committee is a life form with six or more legs and no brain. -- Lazarus Long, "Time Enough For Love"