From: Olaf Hering Subject: Re: [PATCH 05/21] xenpaging: add signal handling Date: Thu, 2 Dec 2010 10:59:14 +0100 Message-ID: <20101202095914.GB29462@aepfle.de> References: <20101126134901.384130351@aepfle.de> <20101126134903.163026660@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: George Dunlap Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Fri, Nov 26, George Dunlap wrote: > Olaf, I haven't been looking at these patches as we've been going > along, but there seem to be two things happening in this patch not > mentioned in the description: This was a "grown" patch. > * Making xenpaging_teardown() not skip when a tear-down item fails, > but continue to try to tear down the rest If a domain is shutting down, xc_mem_event_disable will always fail because d->is_dying is checked. Thats why I removed the bail_out part. > * Making return values for the program as a whole (1 for initializing > the paging, 2 for a failed file open) return codes are currently not perfect, sometimes -1 is leaked. I think xenpaging should either return 0 or 1. > These kinds of things should at least be mentioned in the description; > and I would personally probably pull them out and put them in a > separate patch. Will do better next time. Thanks for the comment. Olaf