From: Wolfgang Denk Date: Thu, 02 Dec 2010 14:58:04 +0100 Subject: [U-Boot] [PATCH] omap3evm: Clean-up EVM detection code. In-Reply-To: <4CF7922B.3020504@free.fr> References: <1291288812-12653-1-git-send-email-premi@ti.com> <20101202113726.2C683EA6600@gemini.denx.de> <4CF7896B.5090007@free.fr> <20101202120141.30416EA6600@gemini.denx.de> <4CF7922B.3020504@free.fr> Message-ID: <20101202135804.3BACFEA6600@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Albert ARIBAUD, In message <4CF7922B.3020504@free.fr> you wrote: > > Now, on an unrelated note, omap3_emv's code arbitrarily uses an u8 where > an int (or enum) would be more appropriate, and this should be changed > not because it removes a linker warning, but because the u8 choice is > arbitrary and at best as effective as using an int, at worst suboptimal > to that. Well, an u8 is as good a data type as any other. The available range of 0...255 seems more than sufficient to store the needed information, so why should I waste 4 bytes of storage when a single byte is sufficient as well? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "You know, after a woman's raised a family and so on, she wants to start living her own life." "Whose life she's _been_ living, then?" - Terry Pratchett, _Witches Abroad_