From: Mike Frysinger Date: Tue, 7 Dec 2010 16:57:41 -0500 Subject: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart In-Reply-To: <20101207215141.3441CD0E429@gemini.denx.de> References: <1287573475-6737-1-git-send-email-vapier@gentoo.org> <201012010634.19596.vapier@gentoo.org> <20101207215141.3441CD0E429@gemini.denx.de> Message-ID: <201012071657.42065.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, December 07, 2010 16:51:41 Wolfgang Denk wrote: > Mike Frysinger wrote: > > hrm, after running this through our test bench, it seems the old code and > > new code are not functionality equivalent. it boils down to default > > values when the env var is not set. some places interpret this to mean > > "yes" while others expect "no". getenv_yesno() takes the "no" default > > which doesnt always work. > > In addition to the default values, there is the difference that the > documentation states that "autostart" has to be set to "yes", i. e. a > plain "y" is not supposed to mean 'yes'. consider it an enhancement then ? i dont see a problem with making the values fuzzier. personally, i make funcs like this accept any of the common strings such as true/false/0/1/y/n/yes/no. > > i can update the API to take a 2nd arg (the default value), or we can > > punt this patch. it's in "next", so there's less pressure to get it > > fixed immediately ... > > I think the easiest way to fix this is to revert the commit. it's in "next", so it could even just be dropped -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20101207/702559df/attachment.pgp