From: Mike Frysinger Date: Tue, 7 Dec 2010 17:32:40 -0500 Subject: [U-Boot] [PATCH] boot cmds: convert to getenv_yesno() with autostart In-Reply-To: <20101207221938.62FA6D0A156@gemini.denx.de> References: <1287573475-6737-1-git-send-email-vapier@gentoo.org> <201012071657.42065.vapier@gentoo.org> <20101207221938.62FA6D0A156@gemini.denx.de> Message-ID: <201012071732.41181.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, December 07, 2010 17:19:38 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > In addition to the default values, there is the difference that the > > > documentation states that "autostart" has to be set to "yes", i. e. a > > > plain "y" is not supposed to mean 'yes'. > > > > consider it an enhancement then ? i dont see a problem with making the > > values fuzzier. personally, i make funcs like this accept any of the > > common strings such as true/false/0/1/y/n/yes/no. > > That should be documented, then. And it should be sensible not to > accept anything. A typo like "yno" should IMHO _not_ be interpreted > as "yes". good point ... i hadnt thought of that > > > I think the easiest way to fix this is to revert the commit. > > > > it's in "next", so it could even just be dropped > > Yes, but then I have to rebase next... imo, keeping the "next" branch clean at the cost of unstableness isnt a problem. this seems to be the convention that Linux started and other people follow. personally, when i use "next" from anywhere, the first thing i do is reset my local "next" branch to whatever the current upstream state. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20101207/6bd7d39b/attachment.pgp