From: Tim Deegan Subject: Re: [RFC][PATCH][VTD] EPT/VT-d page table sharing Date: Thu, 9 Dec 2010 10:12:31 +0000 Message-ID: <20101209101231.GH9912@whitby.uk.xensource.com> References: <201012071220.03624.wei.wang2@amd.com> <20101208100318.GA9912@whitby.uk.xensource.com> <201012081402.39900.wei.wang2@amd.com> <20101208131116.GF9912@whitby.uk.xensource.com> <987664A83D2D224EAE907B061CE93D530193A6BA72@orsmsx505.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Return-path: Content-Disposition: inline In-Reply-To: <987664A83D2D224EAE907B061CE93D530193A6BA72@orsmsx505.amr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Kay, Allen M" Cc: Wei Wang2 , "Han, Weidong" , "xen-devel@lists.xensource.com" , Keir Fraser List-Id: xen-devel@lists.xenproject.org At 18:38 +0000 on 08 Dec (1291833518), Kay, Allen M wrote: > Attached is EPT/VT-d page table sharing patch I mentioned earlier. Basic idea is to leverage 2MB and 1GB page size support in EPT by having VT-d using the same page tables as EPT. When EPT page table changes, flush VT-d IOTLB cache. > > We are still further testing this patch but would appreciate feedbacks. Looks good! Two minor nits: - the path through iommu_set_pgd where the feature gets turned on is a bit confusing. It would be cleaner to have the global flag enabled as part of the general machine init. - while you're moving the p2m bits into avail2, could you rename the avail2 field to p2mt or similar? It would make the rest of the code clearer. Cheers, Tim. > Signed-off-by: Weidong Han > Signed-off-by: Allen Kay -- Tim Deegan Principal Software Engineer, Xen Platform Team Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)