Received: from [140.186.70.92] (port=44713 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PR3CJ-0005At-Fp for qemu-devel@nongnu.org; Fri, 10 Dec 2010 08:39:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PR3CI-0004aG-Gj for qemu-devel@nongnu.org; Fri, 10 Dec 2010 08:39:43 -0500 Received: from verein.lst.de ([213.95.11.210]:52556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PR3CI-0004a9-5j for qemu-devel@nongnu.org; Fri, 10 Dec 2010 08:39:42 -0500 Date: Fri, 10 Dec 2010 14:39:41 +0100 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 4/5] ide: add TRIM support Message-ID: <20101210133941.GB28846@lst.de> References: <20101125135657.GA2814@lst.de> <20101201153504.GA6056@lst.de> <20101201153543.GD6310@lst.de> <4CF7A835.4040905@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CF7A835.4040905@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Christoph Hellwig , qemu-devel@nongnu.org On Thu, Dec 02, 2010 at 03:07:49PM +0100, Kevin Wolf wrote: > This looks wrong. Wouldn't werror=stop cause the request to be retried > as a write when the VM is resumed? Indeed. > But having a copy&paste error gives just about right reason to mention > that after read and write this is the third almost unchanged copy of > this code. Eventually we'll want to refactor this. I've added a patch to refactor the DMA code to the next iteration of the patch series. > While we're at it, do you know why in the eot: case we set > BM_STATUS_INT, but don't actually call ide_set_irq? From what I > understand, those two should always be coupled, but I might be wrong. No idea, sorry.