From: Wolfgang Denk Date: Sun, 12 Dec 2010 22:16:55 +0100 Subject: [U-Boot] arm926ejs, timer: In-Reply-To: <4D01EA19.8070200@emk-elektronik.de> References: <4D01E1EB.5040206@denx.de> <4D01E738.5080600@emk-elektronik.de> <4D01E898.2080103@emk-elektronik.de> <4D01EA19.8070200@emk-elektronik.de> Message-ID: <20101212211655.D4684D4D673@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Reinhard Meyer, In message <4D01EA19.8070200@emk-elektronik.de> you wrote: > Sorry for the noise, but... > > >>> just looked in the timer implementation for arm926ejs based boards, and > >>> found that there is just the at91, davinci, nomadik timer implementation > >>> fixed in actual u-boot. I want to cleanup this timers too, but > >>> there are kirkwood, mb86r0x, orion5x, spear, versatile archs which use > >>> a lastdec var, which is not in global_data.h defined. So the question > >>> is should we add a lastdec to global_data.h or is it Ok, if I use > >>> lastinc for cleaning up? > >> I would suggest to take tbu, tbl, lastinc out of the AT91FAMILY #ifdef > >> to the generic part. > > > > maybe "unify" last{inc,dec} into last_hw ? Because they are supposedly the > > last (hardware) decrementer/incrementer values from the previous call. > > > define 4 u32's in the generic part: > > u32 timer_use1; > u32 timer_use2; > u32 timer_use3; > u32 timer_use4; NAK. Please let's agree on common names. Eventually we will even come up with a common implementation later (with just arch-specific "accessor" routines). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de As far as the laws of mathematics refer to reality, they are not certain; and as far as they are certain, they do not refer to reality. -- Albert Einstein