From: Florian Mickler Subject: Re: [PATCH] [correction] load fbcon from drm_kms_helper Date: Sun, 12 Dec 2010 23:01:28 +0100 Message-ID: <20101212230128.47c20b10@schatten.dmk.lab> References: <20101212183921.GA25744@spacedout.fries.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20101212183921.GA25744@spacedout.fries.net> Sender: linux-kernel-owner@vger.kernel.org To: David Fries Cc: linux-kernel@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sun, 12 Dec 2010 12:39:22 -0600 David Fries wrote: > Kconfig says fbcon is required by drm_kms_helper. If radeon, fbcon, > and drm_kms_helper are all modules, radeon is auto loaded (by PCI id?), > drm_kms_helper is loaded because of the module dependency, but fbcon > isn't loaded leaving the console unusable. Since fbcon is required > and there isn't an explicit module dependency, request the module > to be loaded from drm_kms_helper. > > Signed-off-by: David Fries > Cc: David Airlie > Cc: dri-devel@lists.freedesktop.org > --- > The last patch had a typo 'namue', mental reminder, test again after > running checkpatch.pl. > > This solves compiling CONFIG_FB=m and being left with a blank screen > because the radeon module is automatically loaded, but fbcon isn't. > If radeon had to be manually loaded, then it would be the user's fault > for > not loading fbcon as well, but as radeon is being loaded > automatically, > there isn't much a user can do from console to even fix it. More bug > details from here, > https://bugzilla.kernel.org/show_bug.cgi?id=16221 I guess this is reasonable. Maybe _if_ there actually is a usecase for a drm driver without fbcon, the drm could provide a parameter to skip loading fbcon? But also the drm Kconfig seems to be bogus? SELECT is not transitiv. So selecting DRM_KMS_HELPER is not enough, as it will not select FB and FRAMEBUFFER_CONSOLE. Maybe the drm drivers that currently select DRM_KMS_HELPER should instead depend on it. Sincerely, Flo