From: Wolfgang Denk Date: Mon, 13 Dec 2010 06:38:30 +0100 Subject: [U-Boot] [PATCH] ftgmac100: support of gigabit eth ftgmac100 In-Reply-To: References: <1291969229-3884-1-git-send-email-macpaul@andestech.com> <20101212211355.4FE18D4D673@gemini.denx.de> Message-ID: <20101213053830.137ADB345@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Macpaul Lin, In message you wrote: > > Please take a look at the similar driver "ftmac100.c", > Some coding patterns in "ftgmac100.c" are followed as "ftmac100.c". Oh. Thanks for pointing out. So this other driver needs to be fixed, too. > So I think you've permit that kind of coding style and related issues, > this code of ftgmac100 shouldn't be a problem. ;p The fact that some bad code slips through a review does not mean that it's blessed. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "The number of Unix installations has grown to 10, with more expected." - The Unix Programmer's Manual, 2nd Edition, June, 1972