From: Christoph Hellwig Subject: Re: hpfs_setattr error case avoids unlock_kernel ? Date: Mon, 13 Dec 2010 17:03:04 +0100 Message-ID: <20101213160304.GA6238@lst.de> References: <20101212004947.GA9138@gallifrey> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mikulas@artax.karlin.mff.cuni.cz, hch@lst.de, linux-fsdevel@vger.kernel.org To: "Dr. David Alan Gilbert" Return-path: Received: from verein.lst.de ([213.95.11.210]:57950 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146Ab0LMQDP (ORCPT ); Mon, 13 Dec 2010 11:03:15 -0500 Content-Disposition: inline In-Reply-To: <20101212004947.GA9138@gallifrey> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Dec 12, 2010 at 12:49:47AM +0000, Dr. David Alan Gilbert wrote: > it looks like that 1st 'return error' needs to change into a goto out_unlock; Yes. Care to send a patch to fix it?